[lkml]   [2009]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] perf_counter: Check task on counter read IPI
    In general, code in perf_counter.c that is called through an IPI
    checks, for per-task counters, that the counter's task is still the
    current task. This is to handle the race condition where the cpu
    switches from the task we want to another task in the interval between
    sending the IPI and the IPI arriving and being handled on the target

    For some reason, __perf_counter_read is missing this check, yet there
    is no reason why the race condition can't occur. This adds a check
    that the current task is the one we want. If it isn't, we just
    return. In that case the counter->count value should be up to date,
    since it will have been updated when the counter was scheduled out,
    which must have happened since the IPI was sent.

    Signed-off-by: Paul Mackerras <>
    I don't have an example of an actual failure due to this race, but it
    seems obvious that it could occur and we need to guard against it, so
    I think this should go in .31.

    kernel/perf_counter.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
    index 534e20d..b8fe739 100644
    --- a/kernel/perf_counter.c
    +++ b/kernel/perf_counter.c
    @@ -1503,10 +1503,21 @@ static void perf_counter_enable_on_exec(struct task_struct *task)
    static void __perf_counter_read(void *info)
    + struct perf_cpu_context *cpuctx = &__get_cpu_var(perf_cpu_context);
    struct perf_counter *counter = info;
    struct perf_counter_context *ctx = counter->ctx;
    unsigned long flags;

    + /*
    + * If this is a task context, we need to check whether it is
    + * the current task context of this cpu. If not it has been
    + * scheduled out before the smp call arrived. In that case
    + * counter->count would have been updated to a recent sample
    + * when the counter was scheduled out.
    + */
    + if (ctx->task && cpuctx->task_ctx != ctx)
    + return;
    if (ctx->is_active)

     \ /
      Last update: 2009-08-14 07:41    [W:0.021 / U:5.208 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site