Messages in this thread | | | Date | Mon, 10 Aug 2009 17:54:32 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev |
| |
On Mon 2009-08-10 09:36:52, Greg KH wrote: > On Sun, Aug 09, 2009 at 02:09:02PM +0200, Pavel Machek wrote: > > Hi! > > > > > --- /dev/null > > > +++ b/drivers/base/devtmpfs.c > > > @@ -0,0 +1,367 @@ > > > +/* > > > + * devtmpfs - kernel-maintained tmpfs-based /dev > > > + * > > > + * Copyright (C) 2009, Kay Sievers <kay.sievers@vrfy.org> > > > + * > > > > I'd expect GPL notice here... > > But it's not needed, the overall license of the kernel covers it. >
Maybe. Maybe not, just add the single line there...
> > > +#if defined CONFIG_DEVTMPFS_MOUNT > > > +static int dev_mount = 1; > > > +#else > > > +static int dev_mount; > > > +#endif > > > > > > A bit too many config options? > > It's only 1 option, is that 1 too many for you?
It is two, and this option duplicates commandline option. Maybe its better to use config_cmdline at that point? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |