lkml.org 
[lkml]   [2009]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev
On Sun, Aug 09, 2009 at 02:09:02PM +0200, Pavel Machek wrote:
> Hi!
>
> > --- /dev/null
> > +++ b/drivers/base/devtmpfs.c
> > @@ -0,0 +1,367 @@
> > +/*
> > + * devtmpfs - kernel-maintained tmpfs-based /dev
> > + *
> > + * Copyright (C) 2009, Kay Sievers <kay.sievers@vrfy.org>
> > + *
>
> I'd expect GPL notice here...

But it's not needed, the overall license of the kernel covers it.

> > +#if defined CONFIG_DEVTMPFS_MOUNT
> > +static int dev_mount = 1;
> > +#else
> > +static int dev_mount;
> > +#endif
>
>
> A bit too many config options?

It's only 1 option, is that 1 too many for you?

> > +#ifdef CONFIG_BLOCK
> > +static inline int is_blockdev(struct device *dev)
> > +{
> > + return dev->class == &block_class;
> > +}
> > +#else
> > +static inline int is_blockdev(struct device *dev) { return 0; }
>
> Should this go to header somewhere?

It could go in device.h, but do others need it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-08-10 18:41    [W:0.245 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site