Messages in this thread Patch in this message | | | From | tom.leiming@gmail ... | Subject | [PATCH] driver core:firmware_class:fix memory leak of page pointers array | Date | Thu, 9 Jul 2009 08:16:31 +0800 |
| |
From: Ming Lei <tom.leiming@gmail.com>
The page pointers array is allocated in fw_realloc_buffer() called by firmware_data_write(), and should be freed in release function of firmware device.
Signed-off-by:Ming Lei <tom.leiming@gmail.com> Reported-by:Catalin Marinas <catalin.marinas@arm.com> Acked-by: David Woodhouse <David.Woodhouse@intel.com> --- drivers/base/firmware_class.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index fc46653..2643366 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -180,7 +180,6 @@ static ssize_t firmware_loading_store(struct device *dev, goto err; } /* Pages will be freed by vfree() */ - fw_priv->pages = NULL; fw_priv->page_array_size = 0; fw_priv->nr_pages = 0; complete(&fw_priv->completion); -- 1.6.0.GIT
| |