Messages in this thread Patch in this message | | | Subject | [PATCH] Free the memory allocated by memdup_user() in fs/sysfs/bin.c | From | Catalin Marinas <> | Date | Wed, 08 Jul 2009 11:17:34 +0100 |
| |
Commit 1c8542c7bb replaced kmalloc() with memdup_user() in the write() function but also dropped the kfree(temp). The memdup_user() function allocates memory which is never freed.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Cc: Parag Warudkar <parag.warudkar@gmail.com> --- fs/sysfs/bin.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 9345806..2524714 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -171,6 +171,7 @@ static ssize_t write(struct file *file, const char __user *userbuf, if (count > 0) *off = offs + count; + kfree(temp); return count; }
| |