lkml.org 
[lkml]   [2009]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 4/5] net/netlabel: Add kmalloc NULL tests
    From: Julia Lawall <julia@diku.dk>

    The test on map4 should be a test on map6.

    The semantic match that finds this problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    // <smpl>
    @@
    expression *x;
    identifier f;
    constant char *C;
    @@

    x = \(kmalloc\|kcalloc\|kzalloc\)(...);
    ... when != x == NULL
    when != x != NULL
    when != (x || ...)
    (
    kfree(x)
    |
    f(...,C,...,x,...)
    |
    *f(...,x,...)
    |
    *x->f
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    net/netlabel/netlabel_kapi.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
    index 3ff6f32..6ce0020 100644
    --- a/net/netlabel/netlabel_kapi.c
    +++ b/net/netlabel/netlabel_kapi.c
    @@ -151,7 +151,7 @@ int netlbl_cfg_unlbl_map_add(const char *domain,
    addr6 = addr;
    mask6 = mask;
    map6 = kzalloc(sizeof(*map6), GFP_ATOMIC);
    - if (map4 == NULL)
    + if (!map6)
    goto cfg_unlbl_map_add_failure;
    map6->type = NETLBL_NLTYPE_UNLABELED;
    ipv6_addr_copy(&map6->list.addr, addr6);

    \
     
     \ /
      Last update: 2009-07-30 16:23    [W:0.040 / U:93.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site