Messages in this thread | | | Date | Mon, 27 Jul 2009 11:57:10 +0900 | Subject | Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops | From | Magnus Damm <> |
| |
On Mon, Jul 27, 2009 at 5:52 AM, Frans Pop<elendil@planet.nl> wrote: > On Sunday 26 July 2009, Rafael J. Wysocki wrote: >> In fact, I wouldn't advise anyone to do these conversions mechanically. > > With hindsight I'd say you are correct. > > In that case would it maybe have been better to have a build time warning > about the need to convert drivers rather than a run time one? Run time > warnings have a much higher annoyance factor and will thus "invite" more > people into having a shot at getting rid of them.
I'm the one who added the runtime warning and I agree that a build time warning would have been more suitable. Exacly how to implement that in this specific case is another question. I'm open to suggestions. =)
The purpose was simply to move over to the new interface sooner than later.
> But I guess partly it's also just the nature of this change: it looks > trivial due to the corresponding terms.
It should be pretty trivial. The tricky part is what gets used when in the cases of CONFIG_HIBERNATION and CONFIG_SUSPEND. The dev_pm_ops comment in include/linux/pm.h should guide people in the right direction.
Thanks for your help!
/ magnus
| |