Messages in this thread | | | From | Frans Pop <> | Subject | Re: [PATCH v2 -tip][RFC] serial8250: update to dev_pm_ops | Date | Sun, 26 Jul 2009 22:52:39 +0200 |
| |
On Sunday 26 July 2009, Rafael J. Wysocki wrote: > In fact, I wouldn't advise anyone to do these conversions mechanically.
With hindsight I'd say you are correct.
In that case would it maybe have been better to have a build time warning about the need to convert drivers rather than a run time one? Run time warnings have a much higher annoyance factor and will thus "invite" more people into having a shot at getting rid of them.
But I guess partly it's also just the nature of this change: it looks trivial due to the corresponding terms.
| |