Messages in this thread | | | Date | Wed, 22 Jul 2009 21:57:52 -0700 | Subject | Re: [PATCH] dmaengine: dmatest: add a maximum number of test iterations | From | Dan Williams <> |
| |
On Fri, Jul 3, 2009 at 10:26 AM, Nicolas Ferre<nicolas.ferre@atmel.com> wrote: > The dmatest usually waits for the killing of its kthreads to stop > running tests. This patch adds a parameter that sets a maximum > number of test iterations. > > This feature is quite interesting for debugging when you set a lot of > traces in your dmaengine controller driver. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > drivers/dma/dmatest.c | 15 ++++++++++++++- > 1 files changed, 14 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c > index fb7da51..0131a1f 100644 > --- a/drivers/dma/dmatest.c > +++ b/drivers/dma/dmatest.c > @@ -38,6 +38,11 @@ module_param(max_channels, uint, S_IRUGO); > MODULE_PARM_DESC(max_channels, > "Maximum number of channels to use (default: all)"); > > +static unsigned int iteration_nbr = 0; > +module_param(iteration_nbr, uint, S_IRUGO); > +MODULE_PARM_DESC(iteration_nbr, > + "Iteration number before stopping test (default: infinite)"); > +
This is a minor nit, but for a user facing interface I don't think we should export abbreviated variable names. I'll apply this with the following fixups:
s/iteration_nbr/iterations/ s/Iteration number/Iterations/
...as well as a fix for the checkpatch violation of initializing a static to 0.
Thanks, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |