lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/3] net: serialize hrtimer callback in sched_cbq


On Fri, 17 Jul 2009, Peter Zijlstra wrote:
>
> How would something like the below work for people?

This looks saner.

It was the insanity of having the core timer code know about different
modes that caused all the sily problems.

Having a separate abstraction layer for "I want to get a softirq timeout"
sounds fine, as long as the timer code itself never cares.

That said, I don't think this shoud be a "hrtimer" issue (reflected in
your naming and include file choice). I think this is a softirq or tasklet
(or whatever) issue, and should be named that way.

Why should the timer code (and header files) care about how you can use
tasklets with them? It shouldn't. The timers should be seen as the really
low-level critical code, and the timer code should never need to know
about softirq's or tasklets or whatever.

So I think you shouldmove it to kernel/softirq.c.

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.069 / U:52.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site