Messages in this thread | | | Date | Tue, 14 Jul 2009 09:42:14 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [patch 1/3] net: serialize hrtimer callback in sched_cbq |
| |
On Tue, 14 Jul 2009, Peter Zijlstra wrote: > > Linus really hated the softirq mode, which is what prompted me to change > that. > > Now, it might be he only hated the particular interface and the > resulting code, but I think to remember he simply thought the whole > thing daft.
Yes. And I hated the bugs it had.
Don't make something as core as timers any more complicated. Don't take locks in timers and then complain about deadlocks. If your locking is broken, don't make the core timers be idiotically broken.
Because it was. The code was a total mess to follow, and had bugs.
Linus
| |