Messages in this thread | | | Date | Thu, 16 Jul 2009 17:29:27 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 1/2] tracing/function: fix the return value of ftrace_trace_onoff_callback() |
| |
>> ftrace_trace_onoff_callback() will return error even if we do the >> right operation, for example: >> >> # echo _spin_*:traceon:10 > set_ftrace_filter >> -bash: echo: write error: Invalid argument >> # cat set_ftrace_filter >> #### all functions enabled #### >> _spin_trylock_bh:traceon:count=10 >> _spin_unlock_irq:traceon:count=10 >> _spin_unlock_bh:traceon:count=10 >> _spin_lock_irq:traceon:count=10 >> _spin_unlock:traceon:count=10 >> _spin_trylock:traceon:count=10 >> _spin_unlock_irqrestore:traceon:count=10 >> _spin_lock_irqsave:traceon:count=10 >> _spin_lock_bh:traceon:count=10 >> _spin_lock:traceon:count=10 >> >> We want to set _spin_*:traceon:10 to set_ftrace_filter, it complain >> with "Invalid argument", but the operation is successful. >> So, this patch fix it. >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > Looks good, thanks. > > Acked-by: Frederic Weisbecker <fweisbec@gmail.com> >
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
| |