lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tracing/function: simplify for __ftrace_replace_code()
On Fri, Jul 17, 2009 at 12:30:07PM +0800, Li Zefan wrote:
> >> + if (enable && !(rec->flags & FTRACE_FL_NOTRACE)) {
> >> + if (ftrace_filtered) {
> >> + if (rec->flags & FTRACE_FL_FILTER)
> >> + flag = FTRACE_FL_ENABLED;
> >> + } else
> >> + flag = FTRACE_FL_ENABLED;
> >
> >
> > The above can be factorized in
> >
> > if (!ftrace_filtered || rec->flags & FTRACE_FL_FILTER)
> > flag = FTRACE_FL_ENABLED
> >
>
> I think it's better to put the latter condition into parentheses:
>
> if (!ftrace_filtered || (rec->flags & FTRACE_FL_FILTER))
> flag = FTRACE_FL_ENABLED
>

Ok. Done.



\
 
 \ /
  Last update: 2009-07-17 06:49    [W:0.033 / U:10.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site