lkml.org 
[lkml]   [2009]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] shmem: call set_page_dirty() with locked page
On Tue, 14 Jul 2009, Wu Fengguang wrote:
> Here set_page_dirty() can be moved into the page lock.

Indeed it can, but you've forgotten to mention why you think
that would be a good thing? All I can see is that it would
very very slightly increase the page's lock hold time, which
wouldn't be an improvement: what improvement are you making?

Hugh

>
> CC: Hugh Dickins <hugh@veritas.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> mm/shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/mm/shmem.c
> +++ linux/mm/shmem.c
> @@ -1630,8 +1630,8 @@ shmem_write_end(struct file *file, struc
> if (pos + copied > inode->i_size)
> i_size_write(inode, pos + copied);
>
> - unlock_page(page);
> set_page_dirty(page);
> + unlock_page(page);
> page_cache_release(page);
>
> return copied;


\
 
 \ /
  Last update: 2009-07-14 20:29    [W:0.123 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site