Messages in this thread | | | Date | Tue, 14 Jul 2009 23:33:08 +0800 | From | Américo Wang <> | Subject | Re: [PATCH] shmem: call set_page_dirty() with locked page |
| |
On Tue, Jul 14, 2009 at 05:29:26PM +0800, Wu Fengguang wrote: >Here set_page_dirty() can be moved into the page lock. > >CC: Hugh Dickins <hugh@veritas.com> >Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
>--- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >--- linux.orig/mm/shmem.c >+++ linux/mm/shmem.c >@@ -1630,8 +1630,8 @@ shmem_write_end(struct file *file, struc > if (pos + copied > inode->i_size) > i_size_write(inode, pos + copied); > >- unlock_page(page); > set_page_dirty(page); >+ unlock_page(page); > page_cache_release(page); > > return copied; >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/
-- Live like a child, think like the god.
| |