Messages in this thread | | | Date | Tue, 23 Jun 2009 22:29:37 +0200 | From | Oleg Nesterov <> | Subject | Re: + proc-connector-add-event-for-process-becoming-session-leader.patch added to -mm tree |
| |
> The act of a process becoming a session leader is a useful signal to a > supervising init daemon such as Upstart. ... > @@ -360,8 +360,10 @@ void __set_special_pids(struct pid *pid) > { > struct task_struct *curr = current->group_leader; > > - if (task_session(curr) != pid) > + if (task_session(curr) != pid) { > change_pid(curr, PIDTYPE_SID, pid); > + proc_sid_connector(curr); > + }
Wouldn't it better to change sys_setsid() then? This looks more clear imho, and we can move proc_sid_connector() outside of tasklist_lock.
Note also that __set_special_pids() does not neccessary mean we are becoming a session leader, see daemonize().
Oleg.
| |