Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 1/1] HID: hiddev, fix lock imbalance | Date | Fri, 19 Jun 2009 23:24:11 +0200 |
| |
Add omitted BKL to one switch/case.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> --- drivers/hid/usbhid/hiddev.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c index 9e94215..215b2ad 100644 --- a/drivers/hid/usbhid/hiddev.c +++ b/drivers/hid/usbhid/hiddev.c @@ -527,8 +527,10 @@ static noinline int hiddev_ioctl_usage(struct hiddev *hiddev, unsigned int cmd, goto goodreturn; case HIDIOCGCOLLECTIONINDEX: + i = field->usage[uref->usage_index].collection_index; + unlock_kernel(); kfree(uref_multi); - return field->usage[uref->usage_index].collection_index; + return i; case HIDIOCGUSAGES: for (i = 0; i < uref_multi->num_values; i++) uref_multi->values[i] = -- 1.6.3.2
| |