Messages in this thread | | | Date | Wed, 17 Jun 2009 18:23:03 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH]x86-tsc.c : fix compile warning |
| |
* Frans Pop <elendil@planet.nl> wrote:
> On Wednesday 17 June 2009, Ingo Molnar wrote: > > Ah, and you fixed in what a superior way: you improved the code in > > the process :-) This is how warnings should be fixed really. > > Hmm. Did you also see Pavel's reply to that patch [1]: > ! But that's a bug to be fixed, I'd say? ... actually I believe you are > ! introducing a bug here. Yes, old code would put random numbers in > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing > ! oops there. > > Was his comment incorrect? > > Cheers, > FJP > > [1] http://lkml.org/lkml/2009/5/24/159
hm, Pavel seems right - i missed that. Subrata, mind sending an updated patch?
Thanks,
Ingo
| |