lkml.org 
[lkml]   [2009]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH]x86-tsc.c : fix compile warning
    From
    Date
    On Wed, 2009-06-17 at 18:23 +0200, Ingo Molnar wrote:
    > * Frans Pop <elendil@planet.nl> wrote:
    >
    > > On Wednesday 17 June 2009, Ingo Molnar wrote:
    > > > Ah, and you fixed in what a superior way: you improved the code in
    > > > the process :-) This is how warnings should be fixed really.
    > >
    > > Hmm. Did you also see Pavel's reply to that patch [1]:
    > > ! But that's a bug to be fixed, I'd say? ... actually I believe you are
    > > ! introducing a bug here. Yes, old code would put random numbers in
    > > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
    > > ! oops there.
    > >
    > > Was his comment incorrect?
    > >
    > > Cheers,
    > > FJP
    > >
    > > [1] http://lkml.org/lkml/2009/5/24/159
    >
    > hm, Pavel seems right - i missed that. Subrata, mind sending an
    > updated patch?

    Hmmm. I would try doing that soon.

    Regards--
    Subrata

    >
    > Thanks,
    >
    > Ingo



    \
     
     \ /
      Last update: 2009-06-17 18:57    [W:0.025 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site