lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] voltage regulator updates for 2.6.31-rc1


On Mon, 15 Jun 2009, Mark Brown wrote:

> On Mon, Jun 15, 2009 at 09:29:54AM -0700, Linus Torvalds wrote:
> > On Mon, 15 Jun 2009, Liam Girdwood wrote:
>
> > > include/linux/regulator/lp3971.h | 51 +++
>
> > Why the heck would "lp3971.h" be under "include/linux"? That makes no
> > sense what-so-ever.
>
> > Why isn't it just
>
> > drivers/regulator/lp3971.c
> > drivers/regulator/lp3971.h
>
> It defines a platform data structure for the architecture code which
> instantiates the driver to use to pass configuration to the driver. If
> the header were in drivers/regulator then any system using one of these
> regulators would need to peer into drivers/regulator in order to set up
> the driver.

A quick grep shows:

[torvalds@nehalem linux]$ git grep lp3971.h
drivers/regulator/lp3971.c:#include <linux/regulator/lp3971.h>

ie _nobody_ includes lp3971.h except for lp3971.c.

So tell me again, why is that lp3971.h file separate from the only driver
that uses it?

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.930 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site