lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] voltage regulator updates for 2.6.31-rc1


On Mon, 15 Jun 2009, Liam Girdwood wrote:
>
> drivers/regulator/lp3971.c | 562 ++++++++++++++++++++++++++
> include/linux/regulator/lp3971.h | 51 +++

So I really don't like this.

Why the heck would "lp3971.h" be under "include/linux"? That makes no
sense what-so-ever.

Why isn't it just

drivers/regulator/lp3971.c
drivers/regulator/lp3971.h

instead? There is never any reason for anything but the lp3971 driver to
include its own header file, they should _not_ be split up to be in two
different places.

In fact, why do we have a "include/linux/regulator/" at all? Does anybody
else ever care? I doubt it.

Anyway, I pulled it, but I think this needs to be fixed.

Linus



\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.076 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site