lkml.org 
[lkml]   [2009]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: Add driver for VIA CPU core temperature
On Wed, 10 Jun 2009 17:40:31 +0000 (UTC)
Tomaz Mertelj <tomaz.mertelj@guest.arnes.si> wrote:

> Harald Welte <HaraldWelte <at> viatech.com> writes:
>
> >
> > This is a driver for the on-die digital temperature sensor of
> > VIA's recent CPU models.
> >
> > Signed-off-by: Harald Welte <HaraldWelte <at> viatech.com>
> >
>
> Harald,

You carefully removed Harald from Cc: so he probably didn't read your
email.

> I tested it on 2.6.28.3 kernel on VIA VB7002 motherboard and it does not work
> correctly.
>
> Output form sensors:
>
> via-cputemp-isa-0000
> Adapter: ISA adapter
> Core 0: +0.0 C
>
> On the other hand
> cat '/sys/class/hwmon/hwmon2/device/driver/via-cputemp.0/temp1_input' outputs
> numbers between 25-27.
>

Thanks for testing it.

Harald, please cc myself on updates to this patch.

<looks quickly at the patch>

It has a few trivial coding-style glitches. Please use checkpatch.

Please take a look at using hotcpu_notifier() rather than a bare
register_hotcpu_notifier(). Many ifdefs should fall away as a result.



\
 
 \ /
  Last update: 2009-06-12 00:37    [W:0.141 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site