Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 1/3] ptrace: ptrace_attach: check PF_KTHREAD + exit_state instead of ->mm | Date | Tue, 5 May 2009 19:02:23 -0700 (PDT) |
| |
This changes the order of the already-traced and security checks. It would match the previous behavior to have the ->exit_state and ->ptrace checks before __ptrace_may_access(). This is a small nit, but it could affect whether some existing harmless usage pattern starts generating new access failure logging from security modules (e.g. SELinux avc denials).
I don't see any reason you can't just swap the order back as it was before. If you do that, Acked-by: Roland McGrath <roland@redhat.com>
Thanks, Roland
| |