Messages in this thread | | | Date | Fri, 15 May 2009 11:31:14 -0600 | From | Pete Zaitcev <> | Subject | Re: [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all() |
| |
On Sat, 16 May 2009 00:14:35 +0900, Tejun Heo <tj@kernel.org> wrote:
> @@ -834,12 +829,7 @@ static void ub_end_rq(struct request *rq > error = -EIO; > rq->errors = scsi_status; > } > - rqlen = blk_rq_bytes(rq); /* Oddly enough, this is the residue. */ > - if (__blk_end_request(rq, error, cmd_len)) { > - printk(KERN_WARNING DRV_NAME > - ": __blk_end_request blew, %s-cmd total %u rqlen %ld\n", > - blk_pc_request(rq)? "pc": "fs", cmd_len, rqlen); > - } > + __blk_end_request_all(rq, error); > }
I applaud this. We needed blk_end_this_mudafakin_request() for a long time. Why two underscores?
-- Pete
| |