lkml.org 
[lkml]   [2009]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all()
On Sat, 16 May 2009 00:14:35 +0900, Tejun Heo <tj@kernel.org> wrote:

> @@ -834,12 +829,7 @@ static void ub_end_rq(struct request *rq
> error = -EIO;
> rq->errors = scsi_status;
> }
> - rqlen = blk_rq_bytes(rq); /* Oddly enough, this is the residue. */
> - if (__blk_end_request(rq, error, cmd_len)) {
> - printk(KERN_WARNING DRV_NAME
> - ": __blk_end_request blew, %s-cmd total %u rqlen %ld\n",
> - blk_pc_request(rq)? "pc": "fs", cmd_len, rqlen);
> - }
> + __blk_end_request_all(rq, error);
> }

I applaud this. We needed blk_end_this_mudafakin_request() for a long time.
Why two underscores?

-- Pete


\
 
 \ /
  Last update: 2009-05-15 19:43    [W:0.289 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site