Messages in this thread | | | Date | Sat, 04 Apr 2009 13:20:14 +0100 | From | Darren Salt <> | Subject | Re: [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer |
| |
I demand that Corentin Chary may or may not have written...
>> On the other hand, the default behaviour of the acpi video driver is to >> change the brightness itself and then also to send the even to >> userspace, so I guess if it was going to break things it probably would >> have done already...
> So, I think this patch is ok.
> But there is a thing I don't like is > int brn = -2; > brn = notify_brn(); > if (brn != -2)
> How can brn be -2?
If notify_brn() wasn't called, it will be.
> And why -2?
Because notify_brn() won't return it (and if it ever does, it needs to be fixed). (Yes, I know, "magic numbers" and all that...)
-- | Darren Salt | linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + Lobby friends, family, business, government. WE'RE KILLING THE PLANET.
Opinions for rent. Reasonable rates.
| |