Messages in this thread | | | Date | Sat, 4 Apr 2009 10:33:20 +0200 | Subject | Re: [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer | From | Corentin Chary <> |
| |
> On the other hand, the default behaviour of the acpi video driver is to > change the brightness itself and then also to send the even to > userspace, so I guess if it was going to break things it probably would > have done already...
So, I think this patch is ok.
But there is a thing I don't like is int brn = -2; brn = notify_brn(); if (brn != -2)
How can brn be -2 ? And why -2 ?
-- Corentin Chary http://xf.iksaif.net
| |