lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] SELinux: Remove excessive interrupt disablement
Date
There's no need to disable interrupts with spin_lock_irqsave() inside of
read_lock_irq().

Signed-off-by: David Howells <dhowells@redhat.com>
---

security/selinux/hooks.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)


diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index ba808ef..0702ba6 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -2378,7 +2378,6 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
struct sighand_struct *psig;
u32 osid, sid;
int rc, i;
- unsigned long flags;

osid = tsec->osid;
sid = tsec->sid;
@@ -2410,9 +2409,9 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
* wait permission to the new task SID. */
read_lock_irq(&tasklist_lock);
psig = current->parent->sighand;
- spin_lock_irqsave(&psig->siglock, flags);
+ spin_lock(&psig->siglock);
wake_up_interruptible(&current->parent->signal->wait_chldexit);
- spin_unlock_irqrestore(&psig->siglock, flags);
+ spin_unlock(&psig->siglock);
read_unlock_irq(&tasklist_lock);
}



\
 
 \ /
  Last update: 2009-04-29 14:51    [W:0.547 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site