Messages in this thread | | | Date | Mon, 27 Apr 2009 14:15:56 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update |
| |
On Mon, Apr 27, 2009 at 01:57:00PM +0200, Arnd Bergmann wrote: > On Monday 27 April 2009, Michal Simek wrote: > > Christoph Hellwig wrote: > > > > Given that microblaze only got merged in the 2.6.30 window I would > > > suggest fixing up the nommu variant. > > > > ok. Let's do it. > > Here are stats structures from xtensa. > > > > Arnd: Is it ok for asm-generic? > > I carry a (not cleaned up) tree with changes in my playground > (git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git) > as branch generic-microblaze, where I try to use generic > headers for everything. See below for my version of stat.h. > In particular, it uses 64 bit st_size and st_blocks, but 32 bit > time fields. It also defines struct stat to be identical to > struct stat64 on 64 bit systems. 32 bit systems should only > provide the stat64 syscalls, so the shorter types in struct > stat do not hurt.
Why not use __u64/__u32 (and s32/s64 where appropriate)? Historical baggage or a techncal reason?
Sam
| |