lkml.org 
[lkml]   [2009]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mfd: Mark clocks_init as non-init in twl4030-core.c
From
On 4/19/09, Rakib Mullick <rakib.mullick@gmail.com> wrote:
> Impact: Fix section mismatch.
>
> clocks_init() has been called from twl4030_probe() which is a non-init
> function. Since probing can be done anytime so clocks_init will be
> called anytime too. So we mark clock_init() as non-init.
>
> LD drivers/mfd/built-in.o
> WARNING: drivers/mfd/built-in.o(.text+0x8dd9): Section mismatch in
> reference from the function twl4030_probe() to the function
> .init.text:clocks_init()
> The function twl4030_probe() references
> the function __init clocks_init().
> This is often because twl4030_probe lacks a __init
> annotation or the annotation of clocks_init is wrong.
>
> ---
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
>
> --- linus/drivers/mfd/twl4030-core.c 2009-03-26 06:26:44.000000000 +0600
> +++ rakib/drivers/mfd/twl4030-core.c 2009-03-26 21:51:53.604077256 +0600
> @@ -649,7 +649,7 @@ static inline int __init unprotect_pm_ma
> return e;
> }
>
> -static void __init clocks_init(struct device *dev)
> +static void clocks_init(struct device *dev)
> {
> int e = 0;
> struct clk *osc;
>


\
 
 \ /
  Last update: 2009-04-19 05:01    [W:0.139 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site