Messages in this thread | | | Date | Fri, 10 Apr 2009 21:51:06 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH -tip] x86: acpi/sleep.c saved_magic fix overflow |
| |
On Sat, 11 Apr 2009, Jaswinder Singh Rajput wrote: > Sorry, I was confused by this sparse warning on 64 bit box: > > CHECK arch/x86/kernel/acpi/sleep.c > arch/x86/kernel/acpi/sleep.c:107:16: warning: constant 0x123456789abcdef0 is so big it is long > > atleast I found problem in sparse ;-)
Sigh. There is no problem in sparse. The problem is between keyboard and chair.
Care to read what the warning says ?
warning: constant 0x123456789abcdef0 is so big it is long
It needs to be: 0x123456789abcdef0L
Seriously, this kind of mechanical "fix" warnings no matter what and without actually understanding the issues is more than counter productive.
The point is, you force people into wasting a lot of time into what should have been handled in 10 seconds. This is not efficient at all and you need to improve your ways of communicaton and be more careful about the patches you submit.
Thanks,
tglx
| |