Messages in this thread | | | Date | Fri, 10 Apr 2009 22:15:04 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH -tip] x86: acpi/sleep.c saved_magic fix overflow |
| |
On Sat 2009-04-11 01:19:41, Jaswinder Singh Rajput wrote: > On Fri, 2009-04-10 at 21:29 +0200, Sam Ravnborg wrote: > > On Sat, Apr 11, 2009 at 12:46:56AM +0530, Jaswinder Singh Rajput wrote: > > > Sorry, I was confused by this sparse warning on 64 bit box: > > > > > > CHECK arch/x86/kernel/acpi/sleep.c > > > arch/x86/kernel/acpi/sleep.c:107:16: warning: constant 0x123456789abcdef0 is so big it is long > > > > > > atleast I found problem in sparse ;-) > > > > Sparse tells you that the constant is so big it is long - correct. > > So rather than being implicit appending an L would make sparse happy. > > > > So please use the constant 0x123456789abcdef0L and I think sparse is silenced. > > And code/functionality is the same. > > > > Yes, this fixes the sparse warning, Thanks :-)
Acked-by: Pavel Machek <pavel@ucw.cz>
> diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c > index 7c243a2..3445d0f 100644 > --- a/arch/x86/kernel/acpi/sleep.c > +++ b/arch/x86/kernel/acpi/sleep.c > @@ -104,7 +104,7 @@ int acpi_save_state_mem(void) > initial_gs = per_cpu_offset(smp_processor_id()); > #endif > initial_code = (unsigned long)wakeup_long64; > - saved_magic = 0x123456789abcdef0; > + saved_magic = 0x123456789abcdef0L; > #endif /* CONFIG_64BIT */ > > return 0; > > -- >
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |