lkml.org 
[lkml]   [2009]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git-pull -tip] x86: include inverse Xmas tree patches
On Sun, 29 Mar 2009, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > > Personally I'd prefer alphabetic order, sorting based on length
> > > isn't a complete ordering. Nearly all editors can sort
> > > alphabetically at the push of a key.
> >
> > I'd prefer if somebody would sit down and write a tool to analyse
> > the include hell instead of manually shuffling crap around to
> > avoid trivial merge conflicts. I have cleaned up enough stuff in
> > the x86 merger myself where I was able to cut the number of
> > includes at least in half just by staring at the gcc intermediate
> > files. We could do better and automate the analysis so we get down
> > to a handful of includes instead of including the world and more.
>
> I do not disagree with include file cleanups (we've done many of
> them in this cycle and in previous cycles), but note that the
> reduction in include files at the top of .c files actually increases
> the chance of patch conflicts: when a new include file is added by
> two patches to the same .c file.

Those conflicts are trivial and if we have a mechanism to anlyse
include dependencies then we can avoid such conflicts often at all.

Go through some of the include madness and watch the compiler reading
the same header file ten times for a single source file compile.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-03-29 00:49    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean