Messages in this thread | | | Date | Sun, 29 Mar 2009 03:58:05 +0200 | From | Ingo Molnar <> | Subject | Re: [git-pull -tip] x86: include inverse Xmas tree patches |
| |
* Thomas Gleixner <tglx@linutronix.de> wrote:
> I just run the following on current git: > > # FS=`find -type f`; for F in $FS; do grep -c "#include" $F; done | sort -n | uniq -c > > The top 5 are: > > lib/locking-selftest.c: 108 (justified as this includes all the test cases) > fs/compat_ioctl.c 88 (maybe ok as it is the all in one kitchen sink) > arch/x86/kernel/setup.c: 76 (completely nuts)
[yep]
> init/main.c: 62 (needs to be looked at) > security/selinux/hooks.c 61 (needs to be looked at, spotted at least 5 which can be removed) > > 1400 files have more than 20 includes. 5375 more than 10. > > I think it's well justified to sit down and work on a tool which > helps us analyse and distangle that mess.
yeah.
Ingo
| |