Messages in this thread | | | Subject | Re: [PATCH] posixtimers: Fix posix clock monotonicity v2 | From | Peter Zijlstra <> | Date | Wed, 18 Mar 2009 11:58:07 +0100 |
| |
On Wed, 2009-03-18 at 19:41 +0900, Hidetoshi Seto wrote: > Impact: Regression fix (against clock_gettime() backwarding bug) > > This patch re-introduces a couple of function, task_sched_runtime > and thread_group_sched_runtime, which was once removed at the > time of 2.6.28-rc1. > > These functions protect the sampling of thread/process clock with > rq lock. This rq lock is required not to update rq->clock durling > the sampling. > i.e. > The clock_gettime() may return > ((accounted runtime before update) + (delta after update)) > that is less than what it should be. > > v1 -> v2: > - Revises comments for functions and patch description. > - Add note about accuracy of thread group's runtime. > > Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: stable@kernel.org [2.6.28.x]
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Thanks Hidetoshi-san.
| |