Messages in this thread | | | Subject | Re: [PATCH 1/2] x86: Rename __task_delta_exec() to task_delta_exec_locked() | From | Peter Zijlstra <> | Date | Mon, 23 Mar 2009 08:57:39 +0100 |
| |
On Mon, 2009-03-23 at 14:11 +0900, Hidetoshi Seto wrote: > Externing function with prefix "__" is unpleasant. > This patch renames the function and fix the caller. > This change is desirable for other fix that against posix clocks, > since the fix introduces another __task_delta_exec() which is static.
There's nothing wrong with __ prefixed functions, the core kernel is stuffed with them, and its a well known prefix for functions that need special care. Furthermore your argument seems contradictory in that it introduces one.
| |