Messages in this thread | | | Date | Wed, 18 Mar 2009 19:46:04 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 24/27] Convert gfp_zone() to use a table of precalculated values |
| |
On Wed, Mar 18, 2009 at 03:07:48PM -0400, Christoph Lameter wrote: > On Wed, 18 Mar 2009, Mel Gorman wrote: > > > Thanks.At a quick glance, it looks ok but I haven't tested it. As the intention > > was to get one pass of patches that are not controversial and are "obvious", > > I have dropped my version of the gfp_zone patch and the subsequent flag > > cleanup and will revisit it after the first lot of patches has been dealt > > with. I'm testing again with the remaining patches. > > This fixes buggy behavior of gfp_zone so it would deserve a higher > priority. >
It is buggy behaviour in response to a flag combination that makes no sense which arguably is a buggy caller. Now that I get to think about it a bit more, you can't define a const table in a header. If it's declared extern, then the compiler doesn't know what the constant value is so it can't generate better code. At best, you end up with equivalent code to what my patch did in the first place except __GFP_DMA32|__GFP_HIGHMEM will return ZONE_NORMAL.
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |