lkml.org 
[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 24/27] Convert gfp_zone() to use a table of precalculated values
On Thu, 19 Mar 2009, KAMEZAWA Hiroyuki wrote:

> I wonder why you have to make the bad caller work insane way ?
> Is this bad ?
> ==
> const int gfp_zone_table[GFP_ZONEMASK] = {
> ZONE_NORMAL, /* 00 No flags set */
> ZONE_DMA, /* 01 Only GFP_DMA set */
> ZONE_HIGHMEM, /* 02 Only GFP_HIGHMEM set */
> BAD_ZONE, /* 03 GFP_HIGHMEM and GFP_DMA set */
> ZONE_DMA32, /* 04 Only GFP_DMA32 set */
> BAD_ZONE, /* 05 GFP_DMA and GFP_DMA32 set */
> BAD_ZONE, /* 06 GFP_DMA32 and GFP_HIGHMEM set */
> BAD_ZONE, /* 07 GFP_DMA, GFP_DMA32 and GFP_DMA32 set */
> ZONE_MOVABLE, /* 08 Only ZONE_MOVABLE set */
> ZONE_DMA, /* 09 MOVABLE + DMA */
> ZONE_MOVABLE, /* 0A MOVABLE + HIGHMEM */
> BAD_ZONE, /* 0B MOVABLE + DMA + HIGHMEM */
> ZONE_DMA32, /* 0C MOVABLE + DMA32 */
> BAD_ZONE, /* 0D MOVABLE + DMA + DMA32 */
> BAD_ZONE, /* 0E MOVABLE + DMA32 + HIGHMEM */
> BAD_ZONE /* 0F MOVABLE + DMA32 + HIGHMEM + DMA
> };
> ==

It would work if we could check for BAD_ZONE with a VM_BUG_ON or a
BUILD_BUG_ON. If I get some time I will look into this.



\
 
 \ /
  Last update: 2009-03-19 16:13    [W:0.105 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site