Messages in this thread Patch in this message | | | Date | Thu, 12 Mar 2009 12:28:30 +0000 | From | "Jan Beulich" <> | Subject | [PATCH] remove pointless strdup() on arguments passed to new_module() |
| |
new_module() itself already calls strdup() on its modname parameter.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
--- scripts/mod/modpost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.29-rc7/scripts/mod/modpost.c 2008-12-25 00:26:37.000000000 +0100 +++ 2.6.29-rc7-module-modpost/scripts/mod/modpost.c 2009-01-20 09:47:23.000000000 +0100 @@ -1910,7 +1910,7 @@ static void read_dump(const char *fname, if (!mod) { if (is_vmlinux(modname)) have_vmlinux = 1; - mod = new_module(NOFAIL(strdup(modname))); + mod = new_module(modname); mod->skip = 1; } s = sym_add_exported(symname, mod, export_no(export)); @@ -1994,7 +1994,7 @@ static void read_markers(const char *fna mod = find_module(modname); if (!mod) { - mod = new_module(NOFAIL(strdup(modname))); + mod = new_module(modname); mod->skip = 1; } if (is_vmlinux(modname)) {
| |