Messages in this thread Patch in this message | | | Date | Thu, 26 Feb 2009 21:32:51 +0100 | From | Christoph Hellwig <> | Subject | [hch: [PATCH] fix FREEZE/THAW compat_ioctl regression] |
| |
[I sent this 10 days ago to lkml and fsdevel and didn't get a single reply yet, can we please get this in so we don't have that regression in 2.6.29?]
Commit 8e961870bb9804110d5c8211d5d9d500451c4518 removed the FREEZE/THAW handling in xfs_compat_ioctl but never added any compat handler back, so now any freeze/thaw request from a 32-bit binary ond 64-bit userspace will fail.
As these ioctls are 32/64-bit compatible two simple COMPATIBLE_IOCTL entries in fs/compat_ioctl.c will do the job.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/compat_ioctl.c =================================================================== --- xfs.orig/fs/compat_ioctl.c 2009-02-16 12:48:23.000000000 +0000 +++ xfs/fs/compat_ioctl.c 2009-02-16 12:49:34.000000000 +0000 @@ -1913,6 +1913,9 @@ /* 0x00 */ COMPATIBLE_IOCTL(FIBMAP) COMPATIBLE_IOCTL(FIGETBSZ) +/* 'X' - originally XFS but some now in the VFS */ +COMPATIBLE_IOCTL(FIFREEZE) +COMPATIBLE_IOCTL(FITHAW) /* RAID */ COMPATIBLE_IOCTL(RAID_VERSION) COMPATIBLE_IOCTL(GET_ARRAY_INFO) ----- End forwarded message -----
| |