Messages in this thread | | | Date | Thu, 26 Feb 2009 20:20:56 +0000 | From | Mark Brown <> | Subject | Re: [patch 2.6.29-rc6 1/2] regulator: enumerate voltages (v2) |
| |
On Thu, Feb 26, 2009 at 11:48:36AM -0800, David Brownell wrote:
> Updates since previous version: address feedback, simplify.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This looks good to merge to me - coincidentally I've got a use case for it lined up already. Might it be worth merging the MMC client along with this patch if the relevant maintainers are OK with that, could help get it in faster?
Just two very minor points which might be nice to fix at some point:
> + cmin = INT_MIN; > + cmax = INT_MAX; > + } > + > + /* else require explicit machine-level constraints */ > + else if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
That indentation is going to catch some people out :)
> + /* final: [min_uV..max_uV] valid iff constraints valid */ > + if (max_uV < min_uV) { > + pr_err("%s: %s '%s' voltage constraints\n", > + __func__, "unsupportable", name); > + ret = -EINVAL;
That style is going to hurt grepability for the error.
| |