Messages in this thread | | | Date | Thu, 19 Feb 2009 20:40:39 +0100 | From | Stefan Richter <> | Subject | Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers |
| |
Mauro Carvalho Chehab wrote: > The driver looks sane to my eyes. I found just one minor issue (see bellow). > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Thanks for checking.
>> + >> + /* >> + * AV/C specs say that answers should be sent within 150 ms. >> + * Time out after 200 ms. >> + */ >> + if (wait_event_timeout(fdtv->avc_wait, >> + fdtv->avc_reply_received, >> + HZ / 5) != 0) { > > Instead of using HZ, it would be better to use: > msecs_to_jiffies(200)
OK, I switch this.
(Hmm, what if msecs_to_jiffies could be rolled out to a constant expression if called on a constant argument...?) -- Stefan Richter -=====-==--= --=- =--== http://arcgraph.de/sr/
| |