lkml.org 
[lkml]   [2009]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers
Mauro Carvalho Chehab wrote:
> The driver looks sane to my eyes. I found just one minor issue (see bellow).
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Thanks for checking.

>> +
>> + /*
>> + * AV/C specs say that answers should be sent within 150 ms.
>> + * Time out after 200 ms.
>> + */
>> + if (wait_event_timeout(fdtv->avc_wait,
>> + fdtv->avc_reply_received,
>> + HZ / 5) != 0) {
>
> Instead of using HZ, it would be better to use:
> msecs_to_jiffies(200)

OK, I switch this.

(Hmm, what if msecs_to_jiffies could be rolled out to a constant
expression if called on a constant argument...?)
--
Stefan Richter
-=====-==--= --=- =--==
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2009-02-19 20:45    [W:0.092 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site