Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error() | Date | Mon, 16 Feb 2009 22:17:08 +0100 |
| |
On Monday 16 February 2009, Sergei Shtylyov wrote: > Hello, I wrote: > > >>> register and handle it in ->tf_read. > >>> > >> > >> Doesn't seem like a good name -- you can't read the features > >> register. I should've commented to this patch earlier, of course...
[ Yeah... preferably in June 2008 when this patch was posted... ]
> > * Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature
Trivial s/IN_*FEATURE/IN_*ERROR/ should do the job.
I will fix it later unless you beat me to it.
> > Moreover, the error register shoudn't be affeceted by the HOB bit, > > so this flag doesn't make sense. > > I meant IDE_TFLAG_IN_HOB_FEATURE, of course.
Once again blame the certain ioctl (you know which one)... :)
Thanks, Bart
| |