lkml.org 
[lkml]   [2009]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 14/18] ide: use ->tf_read in ide_read_error()
Date
On Monday 16 February 2009, Sergei Shtylyov wrote:
> Hello, I wrote:
>
> >>> register and handle it in ->tf_read.
> >>>
> >>
> >> Doesn't seem like a good name -- you can't read the features
> >> register. I should've commented to this patch earlier, of course...

[ Yeah... preferably in June 2008 when this patch was posted... ]

> > * Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature

Trivial s/IN_*FEATURE/IN_*ERROR/ should do the job.

I will fix it later unless you beat me to it.

> > Moreover, the error register shoudn't be affeceted by the HOB bit,
> > so this flag doesn't make sense.
>
> I meant IDE_TFLAG_IN_HOB_FEATURE, of course.

Once again blame the certain ioctl (you know which one)... :)

Thanks,
Bart


\
 
 \ /
  Last update: 2009-02-18 12:23    [W:0.160 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site