Messages in this thread Patch in this message | | | Date | Tue, 22 Dec 2009 21:32:28 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 5/6] drivers/scsi: Correct use after free |
| |
From: Julia Lawall <julia@diku.dk>
Move the kfree after a reference to the freed structure.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,e; identifier f; iterator I; statement S; @@
*kfree(x); ... when != &x when != x = e when != I(x,...) S *x->f // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/scsi/dpt_i2o.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 4967643..18c625c 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -1229,12 +1229,13 @@ static void adpt_i2o_delete_hba(adpt_hba* pHba) } } pci_dev_put(pHba->pDev); - kfree(pHba); if (adpt_sysfs_class) device_destroy(adpt_sysfs_class, MKDEV(DPTI_I2O_MAJOR, pHba->unit)); + kfree(pHba); + if(hba_count <= 0){ unregister_chrdev(DPTI_I2O_MAJOR, DPT_DRIVER); if (adpt_sysfs_class) {
| |