Messages in this thread | | | Date | Wed, 2 Dec 2009 15:20:57 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH tip/core/rcu 1/4] rcu: rename "quiet" functions |
| |
On Wed, Dec 02, 2009 at 12:10:13PM -0800, Paul E. McKenney wrote: > The number of "quiet" functions has grown recently, and the names are > no longer very descriptive. The point of all of these functions is to > do some portion of the task of reporting a quiescent state, so rename > them accordingly: > > o cpu_quiet() becomes rcu_report_qs_rdp(), which reports a > quiescent state to the per-CPU rcu_data structure. If this > turns out to be a new quiescent state for this grace period, > then rcu_report_qs_rnp() will be invoked to propagate the > quiescent state up the rcu_node hierarchy. > > o cpu_quiet_msk() becomes rcu_report_qs_rnp(), which reports > a quiescent state for a given CPU (or possibly a set of CPUs) > up the rcu_node hierarchy. > > o cpu_quiet_msk_finish() becomes rcu_report_qs_rsp(), which > reports a full set of quiescent states to the global rcu_state > structure. > > o task_quiet() becomes rcu_report_unblock_qs_rnp(), which reports > a quiescent state due to a task exiting an RCU read-side critical > section that had previously blocked in that same critical section. > As indicated by the new name, this type of quiescent state is > reported up the rcu_node hierarchy (using rcu_report_qs_rnp() > to do so). > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
*Huge* improvement in terminology.
Acked-by: Josh Triplett <josh@joshtriplett.org>
| |