lkml.org 
[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> - pshufb BSWAP, DATA
> + # pshufb BSWAP, DATA
> + .byte 0x66, 0x0f, 0x38, 0x00, 0xc5

A cleanup request: mind creating two macros for this PSHUFB MMX/SSE
instruction in arch/x86/include/asm/i387.h, instead of open-coding the
.byte sequences in ~6 places?

( After the .33 merge window we'll collect such instruction format
knowledge in arch/x86/include/asm/inst.h. That file is not upstream
yet so i387.h will do for now for FPU/SSE instructions. )

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-11-02 08:53    [W:0.084 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site