lkml.org 
[lkml]   [2009]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote:
> >
> > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE
> > instruction in arch/x86/include/asm/i387.h, instead of open-coding the
> > .byte sequences in ~6 places?
>
> I had a go at doing that, but it seems that i387.h isn't really meant
> to be included in an asm file at this point :)

Please use the standard construct and put an #ifndef __ASSEMBLY__ around
it.

> > ( After the .33 merge window we'll collect such instruction format
> > knowledge in arch/x86/include/asm/inst.h. That file is not upstream
> > yet so i387.h will do for now for FPU/SSE instructions. )
>
> I'm happy to revisit this once inst.h exists.

No reason to not do most of the change first though, the way i suggested
it.

Ingo


\
 
 \ /
  Last update: 2009-11-02 15:35    [W:0.056 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site