Messages in this thread | | | Subject | Re: [PATCH] procfs: Use proper units for noMMU statm | From | "Steven J. Magnani" <> | Date | Mon, 16 Nov 2009 08:47:33 -0600 |
| |
On Sat, 2009-11-14 at 12:41 +0800, Américo Wang wrote: > On Fri, Nov 13, 2009 at 07:52:14PM -0600, steve@digidescorp.com wrote: > >On no-MMU systems, sizes reported in /proc/n/statm have units of bytes. > >Per Documentation/filesystems/proc.txt, these values should be in pages. > > > > ... > > > >+ *data = (mm->start_stack - mm->start_data) >> PAGE_SHIFT; > > Are '->start_stack' and '->start_data' already page aligned on NOMMU arch? >
In looking over binfmt_flat.c (main executable type for noMMU systems), I don't think there's a guarantee of more than 32- or 64-bit alignment. Thanks for the suggestion, I'll submit an updated patch.
------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!"
#include <standard.disclaimer>
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |