lkml.org 
[lkml]   [2009]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] procfs: Use proper units for noMMU statm
On Fri, Nov 13, 2009 at 07:52:14PM -0600, steve@digidescorp.com wrote:
>On no-MMU systems, sizes reported in /proc/n/statm have units of bytes.
>Per Documentation/filesystems/proc.txt, these values should be in pages.
>
>Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
>---
>diff -uprN a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
>--- a/fs/proc/task_nommu.c 2009-11-13 16:48:14.000000000 -0600
>+++ b/fs/proc/task_nommu.c 2009-11-13 16:51:09.000000000 -0600
>@@ -110,8 +110,11 @@ int task_statm(struct mm_struct *mm, int
> }
> }
>
>- size += (*text = mm->end_code - mm->start_code);
>- size += (*data = mm->start_stack - mm->start_data);
>+ size >>= PAGE_SHIFT;
>+ *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK))
>+ >> PAGE_SHIFT;
>+ *data = (mm->start_stack - mm->start_data) >> PAGE_SHIFT;

Are '->start_stack' and '->start_data' already page aligned on NOMMU arch?

If yes, this patch looks good.


>+ size += *text + *data;
> up_read(&mm->mmap_sem);
> *resident = size;
> return size;
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/

--
Live like a child, think like the god.



\
 
 \ /
  Last update: 2009-11-14 05:43    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog