Messages in this thread | | | Date | Thu, 29 Oct 2009 16:59:02 +0100 | From | Tejun Heo <> | Subject | Re: [PATCH 1/3] Fix updating of named attribute groups |
| |
Matthew Wilcox wrote: > + if (update) { > + sd = sysfs_get_dirent(kobj->sd, grp->name); > + if (!sd) > + return -ENOENT; > + } else { > + error = sysfs_create_subdir(kobj, grp->name, &sd); > + if (error) > + return error; > + sysfs_get(sd); > + } > + } else { > + sd = sysfs_get(kobj->sd); > + }
nitpick: the last braces aren't necessary.
-- tejun
| |