Messages in this thread | | | Date | Tue, 20 Oct 2009 02:26:02 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 3/3] Expose MSI-X interrupts through a dynamically generated sysfs directory |
| |
I'll note that one of the complaints at the kernel summit has been that people have lost the art of trimming mail they're replying to. There's a proposal to filter mail like the one you sent as spam.
On Tue, Oct 20, 2009 at 04:14:44PM +0800, Am??rico Wang wrote: > On Tue, Oct 20, 2009 at 1:50 PM, Matthew Wilcox <matthew@wil.cx> wrote: > > +#define kobj_to_pci_dev(obj) to_pci_dev(container_of(obj, struct device, kobj)) > > You define this, but no one uses it?
Yeah, left over from an earlier version of the patch. Thanks, I'll remove it.
> > + ?? ?? ?? array = kmalloc((nr_irqs + 1) * sizeof(void *), GFP_KERNEL); > > + ?? ?? ?? if (!array) > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM; > > + ?? ?? ?? attr = kmalloc(nr_irqs * sizeof(*attr), GFP_KERNEL); > > + ?? ?? ?? if (!attr) > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM; > > Here leaks memory allocated above.
Oh, yeah, duh, thanks.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |